Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] - Footnote references #304

Merged
merged 2 commits into from May 19, 2020
Merged

Conversation

csantos1113
Copy link
Contributor

@csantos1113 csantos1113 commented May 11, 2020

This fixes #295.

replaced (.*) with ([^\]]+) , which matches all characters that aren't ]
.
Using options.slugify for the href and id to make sure the footnotes and their references has valid html characters.

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #304 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files           1        1           
  Lines         387      387           
  Branches       65       65           
=======================================
  Hits          384      384           
  Misses          3        3           
Impacted Files Coverage Δ
index.js 99.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b653c7a...27cb1c1. Read the comment docs.

@csantos1113
Copy link
Contributor Author

@probablyup could you pls get this merged when possible? Thanks

Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about footnotes
2 participants