Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML multiline comments bug (#246) #262

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Conversation

eragon512
Copy link
Contributor

@eragon512 eragon512 commented Aug 7, 2019

Closes #246

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #262 into master will decrease coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   99.47%   99.21%   -0.26%     
==========================================
  Files           1        1              
  Lines         382      383       +1     
  Branches       63       63              
==========================================
  Hits          380      380              
- Misses          2        3       +1
Impacted Files Coverage Δ
index.js 99.21% <100%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d5271...5f39545. Read the comment docs.

@quantizor
Copy link
Owner

@eragon512 Can you just inline the regex? (https://github.com/johno/strip-html-comments/blob/master/index.js#L8) We don't need the extra bytes from the "is string" check

@eragon512
Copy link
Contributor Author

@probablyup I have inlined the regex, could you take a look?

Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML multiline comments being rendered
2 participants