Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade esbuild to v0.10.2 #135

Merged
merged 1 commit into from Mar 27, 2021
Merged

chore: upgrade esbuild to v0.10.2 #135

merged 1 commit into from Mar 27, 2021

Conversation

privatenumber
Copy link
Owner

No description provided.

@privatenumber privatenumber merged commit cd0917f into develop Mar 27, 2021
@privatenumber privatenumber deleted the upgrade-esbuild branch March 27, 2021 23:41
privatenumber added a commit that referenced this pull request Mar 27, 2021
@josteph
Copy link

josteph commented Mar 28, 2021

@privatenumber is there any benchmark prior the upgrade to 0.10.2 ?

@privatenumber
Copy link
Owner Author

@josteph All benchmarks shared here are prior to this upgrade

@josteph
Copy link

josteph commented Mar 28, 2021

@privatenumber i meant the benchmark to compare 0.9.x vs 0.10.x

I honestly just tried 0.10.x and I've seen huge amount of performance declines in comparison to 0.9.x. Have you personally tested it?

@privatenumber
Copy link
Owner Author

privatenumber commented Mar 28, 2021

I didn't notice any. What are the differences you're seeing?

Edit:
These are trivial examples but there are no performance regressions here.

@josteph
Copy link

josteph commented Mar 28, 2021

@privatenumber I'll see if I can create a small reproduction of the perf regression, most likely due to using typescript (hopefully not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants