-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-4895: Beacon chain push withdrawals as operations #1369
Comments
7 tasks
4 tasks
Since this is a large task, I'll split it into 3 part
|
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 11, 2023
### Description 1st part of #1369, mainly on pi circuit integration ### Issue Link #1369 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents - `Withdrawal` struct definition and `WdTable` implementation - adding `withdrawals` and `withdrawal_root` in block struct - `wd_table` assignment in pi circuit
blocked by #1652 Withdrawal circuit needs MPT stack trie to verify MPT root but we don't have it now. Issue #1652 was created to address it and Miha probably will work on it next week. Besides, current RLP gadget is more MPT specifc and #1652 will also support RLP constraints as it is for the state trie. |
This was referenced Oct 11, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 27, 2023
…-4896 withdrawals==None (#1688) ### Description Integration Tests have been failing since introduction of #1369, due to Option::Unwrap on None value, when eth_block.withdrawals==None. ### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents - zkevm-circuits/zkevm-circuits/src/witness/block.rs ### Rationale replace eth_block.withdrawals.clone().unwrap() with eth_block.withdrawals.clone().unwrap_or_default() ### How Has This Been Tested? https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/6968928576/job/18963801769 <hr> ### Issue #1687
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature you would like
EIP-4895: Beacon chain push withdrawals as operations
Additional context
Pending analysis of what work should be done.
The text was updated successfully, but these errors were encountered: