Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fork of bitvec by upstream #163

Closed
ed255 opened this issue Nov 11, 2021 · 0 comments · Fixed by #745
Closed

Replace fork of bitvec by upstream #163

ed255 opened this issue Nov 11, 2021 · 0 comments · Fixed by #745
Assignees

Comments

@ed255
Copy link
Member

ed255 commented Nov 11, 2021

In #162 we introduce a fork of bitvec in order to solve an external dependency build error. We have a PR for upstream to solve that: ferrilab/bitvec#141. Once that PR is resolved, we can use bitvec from upstream again.

@ed255 ed255 self-assigned this Nov 11, 2021
ed255 added a commit that referenced this issue Sep 7, 2022
The compliation error comming from the funty dependency of bitvec isn't
happening anymore, so we remove the patched dependency to the forked
bitvec.

Resolve #163
@ed255 ed255 closed this as completed in #745 Sep 7, 2022
ed255 added a commit that referenced this issue Sep 7, 2022
The compliation error comming from the funty dependency of bitvec isn't
happening anymore, so we remove the patched dependency to the forked
bitvec.

Resolve #163
adria0 pushed a commit to adria0/zkevm-circuits that referenced this issue Sep 8, 2022
The compliation error comming from the funty dependency of bitvec isn't
happening anymore, so we remove the patched dependency to the forked
bitvec.

Resolve privacy-scaling-explorations#163
smtmfft added a commit to smtmfft/zkevm-circuits that referenced this issue Oct 30, 2023
omega000133 pushed a commit to omega000133/zkevm-circuits that referenced this issue May 17, 2024
The compliation error comming from the funty dependency of bitvec isn't
happening anymore, so we remove the patched dependency to the forked
bitvec.

Resolve privacy-scaling-explorations/zkevm-circuits#163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant