Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DA] Planetscale engine tests: occ #4471

Open
miguelff opened this issue Nov 21, 2023 · 2 comments
Open

[DA] Planetscale engine tests: occ #4471

miguelff opened this issue Nov 21, 2023 · 2 comments
Labels
topic: driver adapters formerly phase 1

Comments

@miguelff
Copy link
Collaborator

miguelff commented Nov 21, 2023

This is a subcluster of failures after having enabled planetscale tests in #4423

Failing tests in this cluster:

new::occ::occ::occ_delete_test
new::occ::occ::occ_update_many_test
new::occ::occ::occ_update_test

Please follow this process

@miguelff miguelff added the topic: driver adapters formerly phase 1 label Nov 21, 2023
@janpio
Copy link
Member

janpio commented Nov 21, 2023

Is this potentially related to prisma/prisma#21867?

@jkomyno
Copy link
Contributor

jkomyno commented Feb 29, 2024

I confirm that this is related to prisma/prisma#21867.

If our PlanetScale drivers were set up to be using relationMode = "foreignKeys" in the query-engine test suite, the OCC test cases above would pass with both the Vitess("planetscale.js") (Napi) and the Vitess("planetscale.js.wasm") (Wasm) test tags:

test new::occ::occ::occ_update_many_test ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 4.68s
test new::occ::occ::occ_delete_test ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 1.93s
test new::occ::occ::occ_update_test ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1667 filtered out; finished in 1.84s

I'd recommend a refactoring of the connector-test-kit-rs test suite setup to allow opting in and out of relationMode = "prisma" | "foreignKeys", so that we can consistently run CI on e.g. OCC tests with PlanetScale. The specifics of this technical change can be discussed with other engineers in the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: driver adapters formerly phase 1
Projects
None yet
Development

No branches or pull requests

4 participants