fix: order by self-relation #3208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weakky
commented
Sep 20, 2022
Comment on lines
+240
to
243
| let a_col = match previous_join { | ||
| Some(prev_join) => Column::from((prev_join.alias.to_owned(), a.db_name().to_owned())), | ||
| None => a.as_column(), | ||
| }; |
There was a problem hiding this comment.
This ensures that if we do something like: { orderBy: { rel: { self_rel: { id: asc } } } }, the second join relies on the first one.
We used to make sure joins relied on each other slightly differently. This should be more bullet-proof.
Weakky
commented
Sep 20, 2022
Comment on lines
+187
to
+191
| fn join_prefix(&mut self) -> String { | ||
| self.join_counter += 1; | ||
|
|
||
| format!("{}{}", ORDER_JOIN_PREFIX, self.join_counter) | ||
| } |
There was a problem hiding this comment.
I introduced shared state in the order by renderer to make sure we always generate unique join aliases.
garrensmith
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fixes prisma/prisma#12003
fixes prisma/prisma#9929
fixes prisma/prisma#10735
In the case of self-relation ordering, we weren't generating unique join aliases when hoping through multiple relations (of the same table) which was causing a SQL error (because the same aliased table was joined multiple times)