nix: add a derivation for all binaries in flake #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To build it, use `nix build .#prisma-engines`. The binaries will be in `./result/bin`. Pros: - It's an actually reproducible build. - It gives us a more precise picture of our external dependencies. - It's convenient for nix users. - It can be used as a new base for a devShell.
tomhoule
commented
Sep 15, 2022
| )], | ||
| AggregationSelection::Field(field) => { | ||
| vec![(field.db_name().to_owned(), field.type_identifier.clone(), field.arity)] | ||
| } |
There was a problem hiding this comment.
Apparently we merged with failing cargo fmt. Not cool. It was my PR, I don't know how that happened.
pimeys
approved these changes
Sep 15, 2022
| lockFile = ./Cargo.lock; | ||
| # Hashes are required for git dependencies. | ||
| outputHashes = { | ||
| "barrel-0.6.6-alpha.0" = "sha256-USh0lQ1z+3Spgc69bRFySUzhuY79qprLlEExTmYWFN8="; |
There was a problem hiding this comment.
Could we have a updateHashes command to automatically change these?
There was a problem hiding this comment.
Yep that's possible, maybe there's already something in nixpkgs for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build it, use
nix build .#prisma-engines. The binaries will be in./result/bin.Pros: