Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psl: invert the dependency between dml and core #3187

Merged
merged 2 commits into from Sep 14, 2022
Merged

Conversation

tomhoule
Copy link
Contributor

@tomhoule tomhoule commented Sep 14, 2022

We want to isolate dml. Before this commit, datamodel-core depended on
dml. This commit reverses the relationship: dml depends on
datamodel-core. This is a step towards a leaner, better defined
datamodel core.

The second commit is also a step towards a leaner datamodel core (that does not depend on sql_datamodel_connector and mongodb_datamodel_connector) but pretty much unrelated, it may be reviewed separately.

We want to isolate dml. Before this commit, datamodel-core depended on
dml. This commit reverses the relationship: dml depends on
datamodel-core. This is a step towards a leaner, better defined
datamodel core.
The connectors still come from crates datamodel-core depends on, but now
they could come from anywhere else.

The next step will be moving builtin connectors to their own crate, stop
depending on them in datamodel-core, then moving datamodel-connector
into datamodel-core, and injecting the builtin connectors from the psl
crate. We will then have reached our goal of a psl-core crate that does
not depend on any connector but takes them as input.
@tomhoule tomhoule added this to the 4.4.0 milestone Sep 14, 2022
@tomhoule tomhoule marked this pull request as ready for review September 14, 2022 05:34
@tomhoule tomhoule requested a review from a team as a code owner September 14, 2022 05:34
Copy link
Contributor

@pimeys pimeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning ☕

@tomhoule tomhoule merged commit 80833cf into main Sep 14, 2022
@tomhoule tomhoule deleted the psl/dml-free-core branch September 14, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants