qe: fix prisma/14001 #3185
Merged
qe: fix prisma/14001 #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
force-pushed
the
qe/prisma-14001
branch
from
81d4136
to
d4c474a
Compare
tomhoule
force-pushed
the
qe/prisma-14001
branch
from
d4c474a
to
d138cc3
Compare
tomhoule
force-pushed
the
qe/prisma-14001
branch
from
d138cc3
to
23b40ab
Compare
garrensmith
reviewed
Sep 13, 2022
| // Issue: https://github.com/prisma/prisma/issues/14001 | ||
| // Here we can assume the field name is ASCII, because it is the _client_ field name, | ||
| // not the mapped name. | ||
| left[..1].make_ascii_lowercase(); |
There was a problem hiding this comment.
Sorry, I don't understand what left[..1] is doing here?
There was a problem hiding this comment.
It just makes the first character of the left String lowercase (it takes a mutable slice of just the first character, then makes the whole slice lowercase). I'll add a comment to make that less obscure.
garrensmith
approved these changes
Sep 13, 2022
|
Added the tests here prisma/prisma#15327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal spec: https://www.notion.so/prismaio/MongoDB-aggregation-pipeline-variable-names-e6e5c660d39141c28d57040e36414b24
closes prisma/prisma#14001