Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Columns not quoted in returning when using Sqlite #3174

Merged
merged 7 commits into from Sep 20, 2022
Merged

Conversation

do4gr
Copy link
Member

@do4gr do4gr commented Sep 6, 2022

Needs to be fixed in quaint. Maybe do a general sweep of column / table quoting

Fixes prisma/prisma#15177

@do4gr do4gr changed the title Columns not quoted in returning when using Sqlite [Reproduction] Columns not quoted in returning when using Sqlite Sep 6, 2022
@do4gr do4gr added this to the 4.4.0 milestone Sep 7, 2022
@do4gr do4gr changed the title [Reproduction] Columns not quoted in returning when using Sqlite [Fix] Columns not quoted in returning when using Sqlite Sep 20, 2022
Copy link
Contributor

@garrensmith garrensmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 when tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert fails if a table has a space in the name of the primary key
2 participants