Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewer is both a blocker and an approver according to the table. #4

Closed
prince-chrismc opened this issue Dec 29, 2020 · 2 comments
Closed

Reviewer is both a blocker and an approver according to the table. #4

prince-chrismc opened this issue Dec 29, 2020 · 2 comments

Comments

@prince-chrismc
Copy link
Owner

For 3427 uilianries is both a blocker and an approver according to the table. I guess you do not correctly overwrite the old reviews if a new one exists from the same user

Originally posted by @Croydon in #1 (comment)

Moving bug
@prince-chrismc prince-chrismc changed the title Reviewer is both a blocker and an approver according to the table. I guess you do not correctly overwrite the old reviews if a new one exists from the same user Reviewer is both a blocker and an approver according to the table. Dec 29, 2020
@prince-chrismc
Copy link
Owner Author

I guess you do not correctly overwrite the old reviews if a new one exists from the same user

That is exactly correct,

  • still learning golang and I have not found an easy way to reduce the array/slice.
  • There is pagination so not all the reviews come up on the first page, making it a little cumbersome

@prince-chrismc
Copy link
Owner Author

This issue how now been fixed with 884003b

@prince-chrismc prince-chrismc mentioned this issue Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prince-chrismc