Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Dialog to use the Overlay component #2106

Open
jonrohan opened this issue Jun 23, 2023 · 3 comments
Open

Rewrite Dialog to use the Overlay component #2106

jonrohan opened this issue Jun 23, 2023 · 3 comments
Assignees
@keithamus
Labels
component: Dialog rails

Comments

@jonrohan
Copy link
Member

The Dialog component does a lot of work that the Overlay component does. We should move styles and functionality to Overlay under the hood
@github-actions GitHub Actions
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale Automatically marked as stale. label Dec 23, 2023
@lesliecdubs
Copy link
Member

Do y'all think this one is still relevant, @jonrohan @keithamus? 🤔

@github-actions github-actions bot removed the Stale Automatically marked as stale. label Dec 28, 2023
@keithamus
Copy link
Member

Yes we reverted the recent PR for this so this issue will need to live on for a few more weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithamus keithamus

Labels
component: Dialog rails
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonrohan @keithamus @lesliecdubs