Skip to content

Change merged ADR status to Approved #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2023
Merged

Change merged ADR status to Approved #2908

merged 2 commits into from
Feb 21, 2023
+1 −1

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Feb 17, 2023 •
edited
Loading

@siddharthkp
Change status to Approved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
de5b260
@siddharthkp siddharthkp requested review from a team and joshblack February 17, 2023 15:09
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 31b5e7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Feb 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 94.54 KB (0%)
dist/browser.umd.js 95.13 KB (0%)

@siddharthkp siddharthkp temporarily deployed to github-pages February 17, 2023 15:15 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2908 February 17, 2023 15:16 Inactive
@siddharthkp
Merge branch 'main' into adr10-accepted

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
31b5e7c
@siddharthkp siddharthkp temporarily deployed to github-pages February 21, 2023 13:26 — with GitHub Actions Inactive
@siddharthkp siddharthkp added this pull request to the merge queue Feb 21, 2023
Merged via the queue into main with commit 21d1b86 Feb 21, 2023
@siddharthkp siddharthkp deleted the adr10-accepted branch February 21, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siddharthkp @joshblack