Skip to content

Updates documentation based on a11y feedback #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

mperrotti
Copy link
Contributor

Updates documentation based on feedback from the Accessibility team:

  • Adds more info about using accessible labeling in select dropdowns
  • Fixes inaccessible Tooltip example

Closes https://github.com/github/primer/issues/998
Closes #2595

Merge checklist

  • [n/a] Added/updated tests
  • Added/updated documentation
  • [n/a] Tested in Chrome
  • [n/a] Tested in Firefox
  • [n/a] Tested in Safari
  • [n/a] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Sorry, something went wrong.

@mperrotti mperrotti requested review from a team and siddharthkp December 13, 2022 22:25
@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2022

⚠️ No Changeset found

Latest commit: 7039133

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mperrotti mperrotti added the skip changeset This change does not need a changelog label Dec 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 82.8 KB (0%)
dist/browser.umd.js 83.45 KB (0%)

@mperrotti mperrotti temporarily deployed to github-pages December 13, 2022 22:34 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2690 December 13, 2022 22:34 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love the changes for tooltip 🔥

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mperrotti mperrotti temporarily deployed to github-pages December 14, 2022 17:27 — with GitHub Actions Inactive
@mperrotti mperrotti merged commit bce7bf4 into main Dec 14, 2022
@mperrotti mperrotti deleted the mp/form-docs-a11y-considerations branch December 14, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default example for Tooltip is inaccessible
2 participants