Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project-symlink icons #861

Merged
merged 11 commits into from Nov 4, 2022
Merged

Add project-symlink icons #861

merged 11 commits into from Nov 4, 2022

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented Nov 3, 2022

This closes https://github.com/github/primer/issues/1310

Add icons for project-symlink to reference project boards.

project-symlink icons at 16 and 24 pixels. Icon is shaped with a cut out square with a header row and a curved right pointing arrow in the bottom left corner

@ashygee ashygee requested a review from a team as a code owner November 3, 2022 19:01
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2022

🦋 Changeset detected

Latest commit: 94e78bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ashygee ashygee temporarily deployed to github-pages November 3, 2022 19:04 Inactive
@ashygee ashygee temporarily deployed to github-pages November 3, 2022 19:22 Inactive
@gavinmn
Copy link
Contributor

gavinmn commented Nov 3, 2022

In the 24px version, should the left edge of the arrow be a few px further to the right to better align with the layout of the 16px version?

@ashygee
Copy link
Contributor Author

ashygee commented Nov 3, 2022

In the 24px version, should the left edge of the arrow be a few px further to the right to better align with the layout of the 16px version?

Great catch! I have updated the icon and the description image.

@ashygee ashygee temporarily deployed to github-pages November 3, 2022 23:02 Inactive
@ashygee ashygee temporarily deployed to github-pages November 4, 2022 16:38 Inactive
@ashygee ashygee temporarily deployed to github-pages November 4, 2022 16:52 Inactive
@ashygee ashygee merged commit 1a6887d into main Nov 4, 2022
@ashygee ashygee deleted the add-project-symlink branch November 4, 2022 16:59
@primer-css primer-css mentioned this pull request Nov 4, 2022
anhy999 added a commit to anhy999/octicons that referenced this pull request Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants