Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types exports field for TypeScript ESM #925

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Add types exports field for TypeScript ESM #925

merged 1 commit into from
Mar 1, 2023

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Mar 1, 2023

This is required for TypeScript to work under "module": "node16", see https://github.com//microsoft/TypeScript/issues/47792.

@kidonng kidonng requested a review from a team as a code owner March 1, 2023 17:53
@kidonng kidonng requested a review from colebemis March 1, 2023 17:53
@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023

⚠️ No Changeset found

Latest commit: 26cfc32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kidonng! ✨

@colebemis colebemis merged commit 1ccb155 into primer:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants