ci: add workflow for updating package API snapshots #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
colebemis
approved these changes
Nov 4, 2022
.github/workflows/package_api.yml
Outdated
| jobs: | ||
| update: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event.pull_request.head.repo.full_name == 'primer/octicons' && contains(github.event.pull_request.labels.*.name, 'Update Public API') }} |
There was a problem hiding this comment.
Nitpick: How do you feel about calling the label api changes approved? (I don't think we use capital letters in any of our labels)
joshblack
commented
Nov 7, 2022
…ons into ci/add-package-api-workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in a workflow for updating the package API snapshots for
octicons-reactwithout having to pull down the PR and run snapshot tests.This workflow does use the
pull_request_targetevent but guards against misuse by requiring a label to be placed on the Pull Request in order to run. This technique comes from: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ and allows us to check that someone with write permission to the project has "approved" this workflow to run because the label is on the Pull Request.