Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error running ESLint due to conflict with eslint-plugin-primer-react and primer/primitives #168

Closed
khiga8 opened this issue May 6, 2024 · 4 comments
Labels

Comments

@khiga8
Copy link
Contributor

khiga8 commented May 6, 2024

Hi! The latest major version of primer/primitives, 8.1.0, appears to remove the deprecated colors folder which this library relies on. As a result, when a project is on the latest version of primer/primitives and we try to run ESLint, we run into:

Oops! Something went wrong! :(

ESLint: 8.57.0

Error: Failed to load plugin 'primer-react' declared in '--config': Cannot find module '@primer/primitives/dist/deprecated/colors'
Require stack:
- /home/runner/work/code-stats-collector/code-stats-collector/node_modules/eslint-plugin-primer-react/src/rules/no-deprecated-colors.js
- /home/runner/work/code-stats-collector/code-stats-collector/node_modules/eslint-plugin-primer-react/src/index.js
- /home/runner/work/code-stats-collector/code-stats-collector/node_modules/@eslint/eslintrc/dist/eslintrc.cjs

Wanted to flag to see if you have a recommendation forward.

It looks like this surfaced as a conflict in - #167.

@broccolinisoup
Copy link
Member

Hello @khiga8 👋 Thanks for raising this issue! I flagged it in our internal channel, hopefully we will resolve it soon. Apologies for the inconveniences in the meantime 😞

@joshblack
Copy link
Member

Linking the PR that @langermank is working on for this in eslint-plugin-primer-react: #169

Note: this will be a breaking change for the plugin. Let us know if we also want this fixed in the current minor and we can update the peerDependencies to specify < 8 so that it has the right version in node_modules 👍

@joshblack
Copy link
Member

@langermank do you want to be assigned to this because of your PR that will fix this? 👀

@khiga8
Copy link
Contributor Author

khiga8 commented May 15, 2024

This has been fixed, thanks to @langermank PR! :) #174

@khiga8 khiga8 closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants