Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an eslint rule that suggest using the new accessible Tooltip #114

Closed
broccolinisoup opened this issue Nov 10, 2023 · 1 comment · May be fixed by #103
Closed

Create an eslint rule that suggest using the new accessible Tooltip #114

broccolinisoup opened this issue Nov 10, 2023 · 1 comment · May be fixed by #103
Assignees
@broccolinisoup
Labels
react

Comments

@broccolinisoup
Copy link
Member

broccolinisoup commented Nov 10, 2023 •
edited

Based on our team strategy of rolling out breaking accessibility remediations, we need a supporting eslint rule for Tooltip. The rule will suggest using the new accessible tooltip rather than the one in the main bundle.

From

import { Tooltip } from '@primer/react'

to

import { Tooltip } from '@primer/react/next'
@broccolinisoup broccolinisoup self-assigned this Nov 10, 2023
This was referenced Nov 10, 2023
Closed
Open
@broccolinisoup
Copy link
Member Author

Closing this PR since the rule is ready but just waiting to finish the icon button roll out before enabling the rule at dotcom #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@broccolinisoup broccolinisoup

Labels
react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add use-next-tooltip rule primer/eslint-plugin-primer-react
1 participant
@broccolinisoup