Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a lint rule for TriangleDownIcon inside trailingAction #100

Open
joshblack opened this issue Oct 17, 2023 · 2 comments
Open

Create a lint rule for TriangleDownIcon inside trailingAction #100

joshblack opened this issue Oct 17, 2023 · 2 comments
Labels
react size: sand

Comments

@joshblack
Copy link
Member

joshblack commented Oct 17, 2023 •
edited by lesliecdubs

There are scenarios where folks may use TriangleDownIcon inside of trailingVisual instead of trailingAction. This rule should lint against usage in trailingVisual and recommend/auto-fix the usage to be trailingAction. This is for the Button component.
@lesliecdubs
Copy link
Member

@joshblack thanks for filing. Would it be helpful for us to triage this issue in our PRC Planning sync, or is this a placeholder for a task you are planning to take on?

@joshblack
Copy link
Member Author

@lesliecdubs definitely would be useful to triage, I'll add it to the board 👍

Also opened up: #102 to see if we can get them auto-added, as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
react size: sand
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshblack @lesliecdubs