Skip to content

Update tooltips.md to point to PVC Tooltip docs #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

inkblotty
Copy link
Contributor

What are you trying to accomplish?

From this thread, the discoverability of the Tooltip component in PVC was harder than it could be.

What approach did you choose and why?

Just adding a link to the replacement for the deprecated tooltips.

What should reviewers focus on?

How's my verbiage?

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@inkblotty inkblotty requested a review from a team as a code owner October 12, 2022 14:53
@inkblotty inkblotty requested a review from langermank October 12, 2022 14:53
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

⚠️ No Changeset found

Latest commit: 3ebbefc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@emisparkles emisparkles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jonrohan jonrohan merged commit 7a2116f into main Oct 12, 2022
@jonrohan jonrohan deleted the docs/point-to-pvc-tooltip branch October 12, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants