Update Layout's sidebar width values
#1738
Merged
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e05a6a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
reviewed
Nov 4, 2021
| ) !default; | ||
|
|
||
| $sidebar-narrow-width: ( | ||
| md: 240px, | ||
| lg: 256px, | ||
| xl: 296px | ||
| lg: 256px |
There was a problem hiding this comment.
Sharing the output from testing for clarity:
@media (min-width: 768px) {
.Layout.Layout--sidebar-narrow {
--Layout-sidebar-width: 240px;
}
}
@media (min-width: 1012px) {
.Layout.Layout--sidebar-narrow {
--Layout-sidebar-width: 256px;
}
}
| @@ -169,14 +169,12 @@ $responsive-positions: ( | |||
| $sidebar-width: ( | |||
| sm: 220px, | |||
| md: 256px, | |||
| lg: 296px, | |||
| xl: 320px | |||
| lg: 296px | |||
There was a problem hiding this comment.
Output:
@media (min-width: 544px) {
.Layout {
--Layout-sidebar-width: 220px;
}
}
@media (min-width: 768px) {
.Layout {
--Layout-sidebar-width: 256px;
}
}
@media (min-width: 1012px) {
.Layout {
--Layout-sidebar-width: 296px;
}
}
langermank
approved these changes
Nov 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses some previous feedback on the
Layoutcomponent's sidebar widths.With the new values, the default sidebar width is more compact by default, being closer to its previous value. Originally a
col-3on axlwould render as ~280px. With theLayoutcomponent introduction it incorrectly increased to320px. This PR dials it back to 296px.On a desktop computer (
xlbreakpoint), these are the new options:sidebarWidthdefaultnarrowwide✌️
/cc @primer/css-reviewers @camertron @jonrohan