Make sure autocomplete resets button styles #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/pgd4mayvb |
simurai
added this to 🚧 Work in Progress
in 📦 Primer CSS release tracking
via automation
simurai
moved this from 🚧 Work in Progress
to 🔍 Ready to release
in 📦 Primer CSS release tracking
📦 Primer CSS release tracking
automation
moved this from 🔍 Ready to release
to ✅ Approved for release
Jun 29, 2020
📦 Primer CSS release tracking
automation
moved this from ✅ Approved for release
to 💜 Done
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some additional styles to
.autocomplete-item.Currently
autocomplete-itemassumes that the item doesn't come with any UA styles, but in fact they can be blue links or buttons with background colors and borders..autocomplete-resultssets a white background, so it should explicitly set the item text to be something that is dark enough..autocomplete-item:hoversets a blue background with white text, so it should ensure that the non-hover state is styled with non-inverted colors. So we know the hover state is different to the default state.Resetting these items with utility classes wouldn't work as they have higher specificity than
.autocomplete-item/:hover./cc @primer/ds-core
/cc @dinahshi