馃悰 [BUG] - SubNav.Link
marked as current when aria-current="false"
#572
Labels
bug
Something isn't working
SubNav.Link
marked as current when aria-current="false"
#572
Describe the bug
Version
0.32.0
of@primer/react-brand
incorrectly marksSubNav.Link
items as "current" when usingaria-current="false"
. According to MDN,false
is a valid value for this attribute.Currently, the styling for
SubNav.Link
is activated by the mere presence of thearia-current
attribute, rather than by its actual value.brand/packages/react/src/SubNav/SubNav.module.css
Lines 183 to 186 in eaeb50e
Reproduction steps
https://codepen.io/sergioalvz/pen/rNbrbae
Expected behavior
Only elements with
aria-current="page"
oraria-current="true"
are marked as currentScreenshots
No response
Browsers
No response
OS
No response
The text was updated successfully, but these errors were encountered: