Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Animation.module.css in the build and published artifact #409

Open
echarles opened this issue Aug 27, 2023 · 2 comments
Open

Missing Animation.module.css in the build and published artifact #409

echarles opened this issue Aug 27, 2023 · 2 comments
Labels

Comments

@echarles
Copy link

If you build, the imported ./Animation.module.css CSS by useAnimation.ts is not present in the lib folder, nor in the publish npm package, which break consumer of react-brand, especially the ones using Typescript (had build failure while trying to use a Card component).

Screenshot 2023-08-27 at 17 06 40 Screenshot 2023-08-27 at 17 07 32
@echarles
Copy link
Author

This is the error I receive when building:

./node_modules/@primer/react-brand/lib/animation/useAnimation.d.ts:3:20 - error TS2307: Cannot find module './Animation.module.css' or its corresponding type declarations.

3 import styles from './Animation.module.css';
                     ~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in ./node_modules/@primer/react-brand/lib/animation/useAnimation.d.ts:3

@raytalks raytalks added the brand label Nov 10, 2023
@fcollonval
Copy link

The type files for css are generated in the src folder but are not exported in the lib folder. If you can provide pointers to fix this, I can look at fixing it.

I think running tcm with a different output path could do it. But as I'm not familiar with that tool, your input would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants