Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prose: support additional HTML tags #406

Open
stefankp opened this issue Aug 24, 2023 · 2 comments
Open

Prose: support additional HTML tags #406

stefankp opened this issue Aug 24, 2023 · 2 comments
Labels

Comments

@stefankp
Copy link

stefankp commented Aug 24, 2023

https://primer.style/brand/components/Prose

Would be great to add styling support for

  • <blockquote>
  • <b>
  • <i>
  • <u>
  • <sub>
  • <sup>
  • <pre>
  • <code>
@stefankp stefankp changed the title Prose: support Blockquote Prose: support additional HTML tags Aug 24, 2023
@rezrah rezrah added the brand label Aug 24, 2023
@rezrah
Copy link
Collaborator

rezrah commented Sep 4, 2023

👋 @stefankp - we're currently triaging this request.

We can certainly help with some of these like sub, sup, code. Others like i and u we're currently unsure around supporting in Primer Brand generally, as site design are steering away from italicisation of body copy, and instead being very intentional about where we use it. Is this required for enabling rich text editing? Can we limit usage around those styles?

@stefankp
Copy link
Author

stefankp commented Sep 4, 2023

@rezrah awesome. This is the list of elements to complete what Contentful's Rich Text has as default options. We can certainly limit available styles. The highest priority for us are blockquote and code.

Here an example output of rich text rendered to HTML:

Rich Text image
Rendered HTML
<p>Hello World</p>
<h1>Hello World</h1>
<h2>Hello World</h2>
<h3>Hello World</h3>
<h4>Hello World</h4>
<h5>Hello World</h5>
<h6>Hello World</h6>
<p><b>Hello World</b></p>
<p><i>Hello World</i></p>
<p><u>Hello World</u></p>
<p><sup>Hello World</sup></p>
<p><sub>Hello World</sub></p>
<p><code>Hello World</code></p>
<p><a href="https://www.github.com">Hello World</a></p>
<ul>
  <li>
    <p>Hello World</p>
  </li>
  <li>
    <p>Hello World</p>
  </li>
  <li>
    <p>Hello World</p>
  </li>
</ul>
<ol>
  <li>
    <p>Hello World</p>
  </li>
  <li>
    <p>Hello World</p>
  </li>
  <li>
    <p>Hello World</p>
  </li>
</ol>
<blockquote>
  <p>Hello World</p>
</blockquote>
<hr />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants