Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: p-highlight class not being applied to selected options #5646

Closed
omzy opened this issue Apr 26, 2024 · 2 comments
Closed

MultiSelect: p-highlight class not being applied to selected options #5646

omzy opened this issue Apr 26, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@omzy
Copy link

omzy commented Apr 26, 2024

Describe the bug

Seems like this was broken in 3.47.0. When you select an option from the list, the p-highlight class is not being applied to the option (previously it was).

In the reproducer link, which is using 3.46.0, the above issue is NOT occurring. Compare this to the same example in your current documentation site: https://primevue.org/multiselect/#basic

Reproducer

https://stackblitz.com/edit/g1vpgm-pj9d6v

PrimeVue version

3.51.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@omzy omzy added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 26, 2024
@tugcekucukoglu
Copy link
Member

Please track this breaking change: #5105

For backward compatibility, highlightOnSelect can be set true.

@omzy
Copy link
Author

omzy commented Apr 26, 2024

I'm not sure why the default for MultiSelect should be false - was there any specific reason for this change? Also, I noticed the default for Dropdown is true, so there seems to be inconsistent behaviour here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants