Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting Text in Dialog / Modal closes Modal #2597

Open
sebbo2002 opened this issue May 31, 2022 · 0 comments · May be fixed by #5160
Open

Selecting Text in Dialog / Modal closes Modal #2597

sebbo2002 opened this issue May 31, 2022 · 0 comments · May be fixed by #5160
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team

Comments

@sebbo2002
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

CodeSandbox Case (Bug Reports)
https://codesandbox.io/s/wizardly-rgb-rcxms8?file=/index.html

Current behavior

  1. Open a Modal with an input field in it. I added an example above.
  2. Type a value into the input if it's empty.
  3. Select the value with your mouse, while holding down the left mouse key.
  4. Hold the left mouse button and navigate into the modal background area and release the button.
  5. The modal closes.

Expected behavior
The modal should not close if the click was initiated in the modal content. The position of the release of the mouse click should not have an impact on the modal behavior.

Minimal reproduction of the problem with instructions
https://codesandbox.io/s/wizardly-rgb-rcxms8?file=/index.html

What is the motivation / use case for changing the behavior?
People get annoyed when they want to fill in a form in a modal and then close the modal when selecting / copying text. That is a bit unattractive.

  • Vue version:vue@next / vue@latest (see Codesandbox)
  • PrimeVue version: primevue@^3 (see Codesandbox)
  • Browser: all
@tugcekucukoglu tugcekucukoglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants