Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Filtering and Sorting on Editable DataTable #1273

Closed
dottie77hotmail opened this issue May 19, 2021 · 1 comment
Closed

Support for Filtering and Sorting on Editable DataTable #1273

dottie77hotmail opened this issue May 19, 2021 · 1 comment
Assignees
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@dottie77hotmail
Copy link

If you have a PrimeVue PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 1 business hour.

If you do not have a PrimeVue PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Queue Time for Review
Without PRO Support: ~1-4 weeks.
With PRO Support: 1 hour

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

CodeSandbox Case (Bug Reports)
Please demonstrate your case at CodeSandbox by using the issue template below. Issues without a test case have much less possibility to be reviewed in detail and assisted.

Current behavior
Design a datatable to support both:

  • editMode="cell"
  • v-model:filters="filters"

After filtering, clicking on a cell to edit, will cause the filtering to be removed, showing all of the tables rows. Subsequent attempts to filter no longer behave as expected - rows are not filtered out even though the filtering UI responds as expected.

Expected behavior
Existing filtered rows options are expected to remain filtered out when clicking on a cell to edit

Minimal reproduction of the problem with instructions
https://codesandbox.io/s/zealous-paper-ecru3
The 'color' column has a multiselect dropdown for filtering enabled.
The 'year' column has in-place cell editing enabled.

Open the above codesandbox link in a new page (i.e. https://ecru3.csb.app/)
Filter by any color by choosing a color in the dropdown filter above the color column on the far right.
Rows are filtered as expected by the chosen color.
Click on any year from the year column to invoke the in-place cell editing.
Unexpectedly all of the rows appear, causing the InputText editor to jump down to its unfiltered row location.

What is the motivation / use case for changing the behavior?
The current behavior should be considered unexpected, and treated as a bug. The motivation is to correct the defect.

Please tell us about your environment:

  • Vue version: 3.X
    "vue": "^3.0.11"

  • PrimeVue version: 3.4.X
    "primevue": "^3.5.0"

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    I have tried Chrome, Firefox and Edge, all reproduce the issue

@dottie77hotmail
Copy link
Author

This appears to be a regression, downgrading to primevue 3.4.0 has allowed filtering and in-place editing to work together

@cagataycivici cagataycivici self-assigned this Jul 26, 2021
@cagataycivici cagataycivici added this to the 3.6.0 milestone Jul 26, 2021
@cagataycivici cagataycivici changed the title DataTable unable to use filtering together with in-line cell editing Support for Filtering and Cell Editing Jul 26, 2021
@cagataycivici cagataycivici modified the milestones: 3.6.0, 3.6.1 Jul 26, 2021
@cagataycivici cagataycivici removed their assignment Jul 26, 2021
@cagataycivici cagataycivici modified the milestones: 3.6.1, 3.6.2, 3.6.3, 3.6.4 Aug 5, 2021
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Aug 19, 2021
@cagataycivici cagataycivici modified the milestones: 3.7.0, 3.8.0 Aug 31, 2021
@mertsincan mertsincan changed the title Support for Filtering and Cell Editing Support for Filtering, Sorting and Cell Editing on DataTable Oct 2, 2021
@mertsincan mertsincan modified the milestones: 3.8.0, 3.7.3 Oct 2, 2021
@mertsincan mertsincan reopened this Oct 3, 2021
mertsincan added a commit that referenced this issue Oct 4, 2021
mertsincan added a commit that referenced this issue Oct 4, 2021
@mertsincan mertsincan changed the title Support for Filtering, Sorting and Cell Editing on DataTable Support for Filtering and Sorting on Editable DataTable Oct 4, 2021
@mertsincan mertsincan added the Type: Breaking Change Issue contains a breaking change related to a specific component label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants