Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment attach seems wired #275

Closed
fisker opened this issue Sep 7, 2020 · 1 comment · Fixed by #276
Closed

Comment attach seems wired #275

fisker opened this issue Sep 7, 2020 · 1 comment · Fixed by #276
Labels
bug Something isn't working

Comments

@fisker
Copy link
Sponsor Member

fisker commented Sep 7, 2020

In this, comment 1 is attached as endComments,

- a
  # comment 1
- b
  # comment 2

When next one is longer, comment 1 is attached as leadingComments,

- a
  # comment 1
- bb
  # comment 2

Same problem in map

a:
  # comment 1
b:
  # comment 2

VS

a:
  # comment 1
bb:
  # comment 2

Context: prettier/prettier#9143 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(attach): end comments for the first item in block mapping/sequence prettier/yaml-unist-parser
2 participants
@fisker @ikatyang