New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylelint 15 + stylelint-config-prettier-scss #5
Comments
I can at least verify, that setting the |
I had to include it to silence some formatting related warnings. I'd don't remember which though. Another aspect i want to add: Rules which are deprecated by stylelint 15 in favor of prettier are showing up in the output as deprecated when stylelint is executed. I used this stylelintrc:
Is there a way to avoid the deprecation warnings? |
If it's still necessary, could we update the peerDependencies for stylelint, currently: |
^ what he said above running into vulnerabilities in stylelint for an old version but cannot update due to issues with the above |
I believe the answer here would be to stop extending the base Essentially, we remove this line for now: https://github.com/prettier/stylelint-config-prettier-scss/blob/main/src/index.js#L4 ...along with the associated dependency. I've also filed a relevant issue on the stylelint-scss repo that they should follow the same strategy as the core stylelint project, so we can eventually remove the need for this package: stylelint-scss/stylelint-scss#814 |
Fixes prettier#5 * In alignment with Stylelint v15 changes, removes `stylelint-config-prettier` which is no longer needed after rule deprecations and remove from standard recommended config. * Adds stylelint and stylelint-config-recommended-scss as devDeps to allow builds to pass locally and not just in CI * Updated CI config to bump action and dep versions * Drops Node 12 support (Stylelint v15 only supports Node 14+) * Bumps peerDep for stylelint to v15+ * Updates fail test to check for a stylistic rule from the scss standard config (`indentation` was deprecated and removed) * Utilizes new `resolveConfig()` method to get config for checker
I took a stab at a PR to update everything! |
Could folks in this thread validate that that PR fixes their issues? Unfortunately I don't have the time to dedicate to this config anymore and I'm looking for a maintainer. #7 |
@shannonmoeller if you can cut a release or pre-release, I can test on Monday. I also wouldn't mind helping maintain it moving forward, it's a pretty small package. :) |
Published v1.0.0-alpha.0 with the npm install stylelint-config-prettier-scss@next |
I've identified one missing rule, fixed in #8. We should be able to put out a stable release after this. |
I plan to get this out in a release tomorrow. |
Do we need
stylelint-config-prettier-scss
for Stylelint 15?stylelint-config-prettier v9.0.5
already declared:The text was updated successfully, but these errors were encountered: