New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML: Fix format on style[lang="sass"]
#9051
Conversation
tests/html/multiparser/unknown/__snapshots__/jsfmt.spec.js.snap
Outdated
Show resolved
Hide resolved
05d0d72
to
b4c262f
Compare
tests/vue/multiparser/unknow.vue
Outdated
<template lang="unknown"> | ||
foo | ||
bar | ||
</template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename:
unknow.vue → unknown.vue
unknow-lang.html → unknown-lang.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
Hey, guys. I installed a new bot called |
@fisker Looks good. The right URL is https://github.com/kevgo/prettifier What version of Prettier does it use? The one installed in the repo? |
I don't know yet... Just installed about 5 hours. |
foo | ||
bar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One second, I need change this to valid css, because the parser might still be css
and it throws.
@thorn0 It seems it's not running the one installed in the repo |
I'll uninstall it. But, I found it because I was looking for similar bot, maybe we can build one? |
# Conflicts: # src/language-html/utils.js
exports[`unknown.vue format 1`] = ` | ||
====================================options===================================== | ||
parsers: ["vue"] | ||
printWidth: 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for the case --vue-indent-script-and-style
is true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
embeddedLanguageFormatting: "off"
vueIndentScriptAndStyle: true
tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@fisker As for the bot, a GitHub Action is a much more straightforward option for this. E.g. see https://driesvints.com/blog/code-style-formatting-with-github-actions |
Fixes #9050
docs/
directory)changelog_unreleased/*/pr-XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨