Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak build script to not corrupt import-fresh module #7820

Merged
merged 1 commit into from Mar 21, 2020
Merged

Tweak build script to not corrupt import-fresh module #7820

merged 1 commit into from Mar 21, 2020

Conversation

thorn0
Copy link
Member

@thorn0 thorn0 commented Mar 21, 2020

fixes #7818

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@thorn0
Copy link
Member Author

thorn0 commented Mar 21, 2020

test:dist didn't catch it because runPrettier overrides cosmiconfig with the non-bundled module. Let's investigate this problem with tests later in a separate issue.

@thorn0 thorn0 merged commit c9225ca into prettier:master Mar 21, 2020
@thorn0 thorn0 deleted the 2.0-regression-fix branch March 21, 2020 22:46
@thorn0 thorn0 mentioned this pull request Mar 21, 2020
Closed
@thorn0 thorn0 mentioned this pull request Apr 20, 2020
Merged
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.0] Invalid configuration file ...: parent.eval is not a function
1 participant
@thorn0