Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove require from UMD bundles #12485

Merged
merged 15 commits into from Mar 23, 2022
Merged

Remove require from UMD bundles #12485

merged 15 commits into from Mar 23, 2022

Conversation

fisker
Copy link
Member

@fisker fisker commented Mar 18, 2022

Description

Fixes #12338

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker fisker changed the title [WIP] Fix 12338 Remove require in UMD bundles Mar 18, 2022
@fisker fisker changed the title Remove require in UMD bundles Remove require from UMD bundles Mar 18, 2022
Comment on lines 60 to 63
output: {
path: TEMPORARY_DIRECTORY,
filename: getRandomFileName(name),
},
Copy link
Member Author

@fisker fisker Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait Do you know how to prevent webpack write file to disk?

@fisker fisker marked this pull request as ready for review March 18, 2022 08:53
# Conflicts:
#	scripts/build/config.mjs
#	scripts/build/esbuild-plugins/replace-text.mjs
@fisker
Copy link
Member Author

fisker commented Mar 23, 2022

Merging this, so I can work on #12493.

@fisker fisker merged commit 4250812 into prettier:main Mar 23, 2022
@fisker fisker deleted the issue-12338 branch March 23, 2022 02:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression TypeScript parser: "Critical dependency: the request of a dependency is an expression"
1 participant