Improve formatting for empty tuple types #11884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
approved these changes
Nov 30, 2021
fisker
reviewed
Nov 30, 2021
Co-authored-by: fisker Cheung <lionkay@gmail.com>
fisker
reviewed
Nov 30, 2021
| node[typesField].length > 0 && | ||
| getLast(node[typesField]).type === "TSRestType"; | ||
| const types = node[typesField]; | ||
| const isNotEmptyTuple = isNonEmptyArray(types); |
There was a problem hiding this comment.
Let's use isNonEmptyTuple or just isNonEmpty to keep consistent with the function name?
fisker
approved these changes
Nov 30, 2021
sosukesuzuki
added a commit
that referenced
this pull request
Dec 4, 2021
* Don't print trailing comma when tuple is empty * Add tests * Don't print softline * Add tests * Update tests * Add changelog * Update changelog_unreleased/typescript/11884.md Co-authored-by: fisker Cheung <lionkay@gmail.com> * Fix names Co-authored-by: fisker Cheung <lionkay@gmail.com>
dirgam92
approved these changes
Feb 27, 2022
| @@ -0,0 +1,32 @@ | |||
| #### Improve formatting for empty tuple types (#11884 by @sosukesuzuki) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11878
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨