Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scss] Wildcard syntax in @forward broken #11482

Closed
Michsior14 opened this issue Sep 9, 2021 · 3 comments · Fixed by #11487
Closed

[scss] Wildcard syntax in @forward broken #11482

Michsior14 opened this issue Sep 9, 2021 · 3 comments · Fixed by #11487
Labels
lang:css/scss/less Issues affecting CSS, Less or SCSS type:bug Issues identifying ugly output, or a defect in the program

Comments

@Michsior14
Copy link

Using the latest prettier wildcard syntax is broken when using @forward pattern.
It worked as desired in v2.3.2.

Prettier 2.4.0
Playground link

--parser scss

Input:

@forward './path' as path-*;
@forward './color' as color-*;
@forward './element' as element-*;

Output:

@forward "./path" as path- *;
@forward "./color" as color- *;
@forward "./element" as element- *;

Expected behavior:

Wildcard syntax should be preserved.

@forward "./path" as path-*;
@forward "./color" as color-*;
@forward "./element" as element-*;
@alexander-akait
Copy link
Member

Regression, thanks

@alexander-akait alexander-akait added lang:css/scss/less Issues affecting CSS, Less or SCSS type:bug Issues identifying ugly output, or a defect in the program labels Sep 9, 2021
@alexander-akait
Copy link
Member

alexander-akait commented Sep 9, 2021 •
edited

Due #11461

/cc @niksy

niksy added a commit to niksy/prettier that referenced this issue Sep 10, 2021
@niksy
Fix wildcard syntax in @forward (prettier#11482)
6ca2e51
@niksy niksy mentioned this issue Sep 10, 2021
Merged
4 tasks
niksy added a commit to niksy/prettier that referenced this issue Sep 10, 2021
@niksy
Fix wildcard syntax in @forward (prettier#11482)
9aa02da
niksy added a commit to niksy/prettier that referenced this issue Sep 10, 2021
@niksy
Fix wildcard syntax in @forward (prettier#11482)
f83ec5c
@niksy
Copy link
Contributor

niksy commented Sep 10, 2021 •
edited

@Michsior14 oh wow, sorry, I didn’t see that single whitespace in snapshot 😞

@alexander-akait PR created!

niksy added a commit to niksy/prettier that referenced this issue Sep 13, 2021
@niksy
Fix wildcard syntax in @forward (prettier#11482)
fbafa66
sosukesuzuki pushed a commit that referenced this issue Sep 16, 2021
@niksy @thorn0
Fix wildcard syntax in @forward (#11482) (#11487)
59b5eb4 
* Fix wildcard syntax in `@forward` (#11482)

* Add additional tests

* Apply suggestions from code review

Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>

Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>
esanzgar added a commit to hypothesis/client that referenced this issue Sep 20, 2021
@esanzgar
Prettier format fix for scss @forward
7b64c8d 
prettier/prettier#11482
robertknight pushed a commit to hypothesis/client that referenced this issue Sep 22, 2021
@esanzgar @robertknight
Prettier format fix for scss @forward
6108e4b 
prettier/prettier#11482
@sync-by-unito sync-by-unito bot mentioned this issue Oct 1, 2021
Closed
@kachkaev kachkaev mentioned this issue Nov 18, 2021
Merged
1 task
@sync-by-unito sync-by-unito bot mentioned this issue Dec 1, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
lang:css/scss/less Issues affecting CSS, Less or SCSS type:bug Issues identifying ugly output, or a defect in the program
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wildcard syntax in @forward (#11482) niksy/prettier
3 participants
@niksy @Michsior14 @alexander-akait