Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2.2 blog post #9589

Merged
merged 24 commits into from Nov 20, 2020
Merged

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Nov 4, 2020

Can anyone please review English?

Preview

@sosukesuzuki sosukesuzuki mentioned this pull request Nov 4, 2020
13 tasks
@fisker

This comment has been minimized.

@fisker
Copy link
Member

fisker commented Nov 4, 2020

Need revert #9209

@sosukesuzuki
Copy link
Member Author

sosukesuzuki commented Nov 4, 2020

Has been #9209 reverted at #9500 already?


#### Support TypeScript 4.1 via Babel ([#9473](https://github.com/prettier/prettier/pull/9473) by [@sosukesuzuki](https://github.com/sosukesuzuki))

`--parser=babel-ts` is required.
Copy link
Member

@kachkaev kachkaev Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth including a sentence on the future plans? As a Prettier+TS user who is not rushing to try 4.1 features, should I do anything with my projects’ configs? Or can I just wait for Prettier 2.3?

If I do want to try out TS 4.1 stuff, what would my config file need to contain?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to improve the changelog. WDYT? 5091e02
/cc @fisker @thorn0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clearly better now! One extra thing I would add is a sentence on the expected longevity of this override. As a developer who is planning to use TS 4.1, 4.2 and so on in the future, do I have to keep the override in my config file from now on and forever? Or is it just some temporary thing until, say, Prettier v2.3 is released, after which I can remove the hack?

Personally, I’m not rushing to use TS 4.1 features, but I might need them in a couple of months. The practical question I have is if I should bother updating my shared prettier config with this override or just wait for the next release of Prettier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That's certainly important. I've fixed 09f0c22

@thorn0
Copy link
Member

thorn0 commented Nov 4, 2020

Remember not to edit the generated file directly.

@sosukesuzuki sosukesuzuki marked this pull request as ready for review November 10, 2020 05:28
This was referenced Mar 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants