Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.2 patch release #9137

Closed
5 tasks done
sosukesuzuki opened this issue Sep 3, 2020 · 13 comments
Closed
5 tasks done

v2.1.2 patch release #9137

sosukesuzuki opened this issue Sep 3, 2020 · 13 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself

Comments

@sosukesuzuki
Copy link
Member

sosukesuzuki commented Sep 3, 2020

Let's cherry-pick these PR commits into the patch-release branch and release it from there as v2.1.2

regressions


Anything else?

@sosukesuzuki sosukesuzuki added the type:meta Issues about the status of Prettier, or anything else about Prettier itself label Sep 3, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

@sosukesuzuki how will the cherry pick be done

@GrahamCampbell
Copy link

@karenefereyan git cherry-pick?

@sosukesuzuki
Copy link
Member Author

Yes, I'm going to git cherry-pick above PR commits into path-release branch then release the branch

@kachkaev
Copy link
Member

kachkaev commented Sep 5, 2020

Happy to submit a quick patch for #9155 if it’s not too late 🙂

@ghost
Copy link

ghost commented Sep 6, 2020

@GrahamCampbell yes

@fisker
Copy link
Sponsor Member

fisker commented Sep 7, 2020

I'll work on this

Who? @sosukesuzuki? @kachkaev said, he want work on it.

@sosukesuzuki
Copy link
Member Author

Oh, I misunderstood. I'll edit issue description, sorry.

@skevy
Copy link

skevy commented Sep 14, 2020

@sosukesuzuki what are the chances we could put out a patch release with the fixes that have already merged? Based on my read of #9155 it seems like it might be a bit more involved to fix (let me know if I’m wrong about that). If that’s the case, it might be good to just release what’s there now to unblock people on these regressions in 2.1?

@sosukesuzuki
Copy link
Member Author

@skevy Yes, I think we can release with the fixes that have already merged. @fisker @kachkaev What do you think?

@sosukesuzuki
Copy link
Member Author

If they don't reply, I'll release 2.1.2 tomorrow.

@fisker
Copy link
Sponsor Member

fisker commented Sep 15, 2020

I responsed with a thumb up, I'm okay to make a release, #9155 seems not going to get fixed for a while.

@skevy
Copy link

skevy commented Sep 16, 2020

Awesome, thanks @sosukesuzuki and @fisker! My colleagues will be very happy to have pretty formatted GraphQL directives again. :)

@sosukesuzuki
Copy link
Member Author

I've published 2.1.2!

@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Dec 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself
Projects
None yet
Development

No branches or pull requests

5 participants