New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(TypeScript): test ...infer type with parens #9056

Merged

fisker merged 1 commit into prettier:master from brodybits:test-rest-infer-type-with-parens

Aug 26, 2020

Contributor

brodybits commented Aug 25, 2020

In followup to PR #9044, I was thinking it may be good to test that these cases continue to be handled correctly:

// should remove parens from this, to avoid a type issue with TypeScript 4.0:
type Tail2<T extends any[]> = T extends [infer U, ...(infer R)] ? R : never;

// but not remove parens from this:
type Tail3<T extends any[]> = T extends [infer U, ...(infer R)[]] ? R : never;

I’ve added tests to confirm my change works.
I’ve read the contributing guidelines.

✨Try the playground for this PR✨


          test ...infer type with parens

c663748

fisker approved these changes

View reviewed changes

alexander-akait approved these changes

View reviewed changes

fisker merged commit 77c8da7 into prettier:master

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.