Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Quick fix for #8639 #9035

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 24, 2020

Local checked, seems working

image

Regression on build script cause by #8639

Before, require('parse-*') is "Dynamic Require", now it's not, this will slow down prettier, I'll try to find a way or revert that PR.

posted in #8882 (comment)


  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@fisker
Copy link
Member Author

fisker commented Aug 24, 2020

@sosukesuzuki I think we are good, you can merge it and start the release.

Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm checking now that this works fine on my local, please wait.

Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@sosukesuzuki sosukesuzuki merged commit 5223b78 into prettier:master Aug 24, 2020
@fisker fisker deleted the build-script-fix branch August 24, 2020 10:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants