Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing of next point release? #8776

Closed
gkz opened this issue Jul 16, 2020 · 15 comments
Closed

Timing of next point release? #8776

gkz opened this issue Jul 16, 2020 · 15 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself

Comments

@gkz
Copy link
Contributor

gkz commented Jul 16, 2020

Hi, thank you for being such active maintainers of Prettier! PRs get reviewed very quickly.

I was just wondering if there is a timeline for the next point release (2.0.6).

Thanks!

@alexander-akait
Copy link
Member

/cc @thorn0 What do you think about new release?

@thorn0
Copy link
Member

thorn0 commented Jul 17, 2020

There is a bunch of things in master that need to be finished before releasing 2.1. If some specific fix urgently needs to be released, we can cherry-pick it into the patch-release branch and release it from there. That's how 2.0.5 was done.

@thorn0 thorn0 added the type:meta Issues about the status of Prettier, or anything else about Prettier itself label Jul 17, 2020
@gkz
Copy link
Contributor Author

gkz commented Jul 17, 2020

Ah OK, so master is tracking a future 2.1 release rather than a 2.0.6 release, makes sense. I recently had #8768 merged and was just wondering what the approximate time frame would be for it being released. It's not super urgent.

@bakkot
Copy link
Collaborator

bakkot commented Jul 17, 2020

@thorn0 which things in master need to be finished before releasing 2.1? Is there a reason it can't be released now, so that features like #7875 can go out, and whatever those other things are be pushed to 2.2?

@thorn0
Copy link
Member

thorn0 commented Jul 17, 2020

@bakkot

@bakkot
Copy link
Collaborator

bakkot commented Jul 17, 2020

@thorn0 If those PRs weren't good enough to ship, shouldn't they be backed out and re-landed once they're done? I'd be happy to do that if you'd like.

@thorn0
Copy link
Member

thorn0 commented Jul 17, 2020

@bakkot I'm fine with reverting #7889 but not remark. That update is really long-overdue and fixes too many issues.

@justingrant
Copy link

I've been eagerly waiting for #4216 (the fix to #4926) which I'm hoping will fix the issue with VSCode randomly indenting every line in a class method when I paste one line of code into it. If you do end up doing a point release instead of 2.1, it'd be great to see that fix in it.

P.S. - Prettier is wonderful. Thanks so much for maintaining it!

@sosukesuzuki
Copy link
Member

sosukesuzuki commented Jul 28, 2020

/cc @thorn0
We've finished #8630 so I think we can revert #7889 and work for releasing 2.1.

@sosukesuzuki
Copy link
Member

@fisker @evilebottnawi @thorn0 What about other todos in 2.1 milestone? Should we postpone implementing them until 2.2? I'm not sure about status.

@alexander-akait
Copy link
Member

Agree, we can postpone other changes to 2.2 and do release 2.1 (markdown fixes)

@sosukesuzuki sosukesuzuki mentioned this issue Jul 29, 2020
2 tasks
@sosukesuzuki
Copy link
Member

Okay I've created PR reverts 7889. And I'll remove other changes from 2.1 milestone.

@alexander-akait
Copy link
Member

/cc @thorn0 What do you think?

@sosukesuzuki
Copy link
Member

I opened 2.1 checklist issue #8882

@sosukesuzuki
Copy link
Member

We've already released 2.1:+1:

@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Nov 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:meta Issues about the status of Prettier, or anything else about Prettier itself
Projects
None yet
Development

No branches or pull requests

6 participants