An attempt to fix unexpected GitHub Actions failures #7980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this is it. Does GitHub announce such changes anywhere? |
|
Great! |
|
How about |
|
It's not dynamic. Why define this option as a function? |
|
I was thinking |
fisker
approved these changes
Apr 7, 2020
thorn0
added a commit
that referenced
this pull request
Apr 11, 2020
brodybits
added a commit
to brodybits/prettierx
that referenced
this pull request
Apr 13, 2020
based on: prettier/prettier#7980 by @thorn0 the updates from this CI workaround are expected to be overwritten by a future merge of Prettier post-2.0.4 from prettier/prettier master Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com> Co-authored-by: Christopher J. Brody <chris.brody+brodybits@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like GitHub Actions have the
CIenvironment variable set now whereas some tests (added in #5804) depended on this variable.docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨