Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove azure pipelines #7824

Merged
merged 40 commits into from Mar 23, 2020
Merged

Remove azure pipelines #7824

merged 40 commits into from Mar 23, 2020

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Mar 22, 2020

Include codes from #7431

  • Remove .azure-pipelines/*
  • Remove azure-pipelines.yml
  • Remove html cobertura reporter from jest config
  • Remove jest-junit

More?

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker
Followup work on setup github actions
412bb10
@fisker
Coverage report & split prod_lint
d49207d
@fisker
Add env
254278e
@fisker
Remove coverage report on azure pipelines
2735e45
@fisker
Remove build step on lint
ad855a1
@fisker
remove coverage report on prod_test
273381d
@fisker
Use ci-info instead of is-ci
d55836f
@fisker
Always enable ENABLE_TEST_RESULTS and AST_COMPARE on CI
3ff3798
@fisker
Merge branch 'ci-env' into adjust-github-actions
689e14e
@fisker
Standalone test and remove some env
d38e456
@fisker
coverage report
19d8967
@fisker
reduce matrix
6f55df1
@fisker
Merge branch 'next' into adjust-github-actions
7df8ef8 
# Conflicts:
#	.github/workflows/lint.yml
@fisker
standalone test
9275fc2
@fisker
Merge branch 'next' into adjust-github-actions
f1133ad 
# Conflicts:
#	.github/workflows/lint.yml
@fisker
Merge branch 'next' into adjust-github-actions
a63f1a5
@fisker
ci-info
ce57952
@fisker
Remove token
5edd2de
@fisker
Disable coverage on azure pipelines
404c81c
@fisker
use master version of codecov-action
7815cc5
@fisker
Link to master status
838e0f7
@fisker
fix prod lint
767ffb6
@fisker
Use boolean env
869bf20
@fisker
Remove locv report
57ecc9a
@fisker
Merge branch 'next' into adjust-github-actions
3dcbf7d
@fisker
Try lcov report
7e61875
@fisker
pin codecov-action version, enable verbose
53f55fa
@fisker
Merge branch 'next' into adjust-github-actions
293c0c7
@fisker
azure coverage
f2fb408
@fisker
Name
e13fc68
@fisker fisker mentioned this pull request Mar 22, 2020
Merged
3 tasks
@fisker
Merge branch 'master' into remove-azure-pipelines
2a3bb70 
# Conflicts:
#	.azure-pipelines/steps/publish-code-coverage.yml
#	jest.config.js
@thorn0 thorn0 merged commit 34115cb into prettier:master Mar 23, 2020
@fisker fisker deleted the remove-azure-pipelines branch March 23, 2020 10:02
@thorn0
Copy link
Member

thorn0 commented Mar 23, 2020

Any idea why commits to master aren't deployed to prettier.io? E.g. fac9ce0

@thorn0 thorn0 mentioned this pull request Mar 23, 2020
Merged
@fisker
Copy link
Sponsor Member Author

fisker commented Mar 23, 2020

I have no idea.

Did we change something on netlify website? When we are on next?

@lipis
Copy link
Member

lipis commented Mar 23, 2020

Was it Azure?

@thorn0
Copy link
Member

thorn0 commented Mar 23, 2020

Sorry, false alarm. That docs update was published to /docs/en/next, here: https://prettier.io/docs/en/next/install.html

@thorn0
Copy link
Member

thorn0 commented Mar 23, 2020

However the coverage doesn't work. We consistently get this error:

ERROR: The coverage upload was rejected because the workflow run is either not in-progress or finished a while ago. Please make sure the workflow run is in-progress and is not stale for uploads to process correctly.
##[error]Codecov failed with the following error: The process 'bash' failed with exit code 1

https://github.com/prettier/prettier/runs/528790846#step:6:36

@fisker
Copy link
Sponsor Member Author

fisker commented Mar 23, 2020 •
edited

I got this error first on #7431 too, and turns green in 7e61875 , I guess the file format is not the real reason.

Maybe because our test cost too much time?

I searched this error message before, didn't get too much usefully information.

@fisker
Copy link
Sponsor Member Author

fisker commented Mar 23, 2020 •
edited

Maybe we can try upload coverage with token? https://github.com/codecov/codecov-action/blob/master/README.md#arguments

@thorn0
Copy link
Member

thorn0 commented Mar 23, 2020 •
edited

GitHub Actions have been having problems lately (even though githubstatus.com doesn't admit that). Let's see how the coverage will work when GH Actions are back to normal.

@fisker
Copy link
Sponsor Member Author

fisker commented Mar 23, 2020

I read the azure config file again , seems we are missing one test, https://github.com/prettier/prettier/pull/7824/files#diff-fec826feae04e51c0d94076385408bdcL25

@thorn0
Copy link
Member

thorn0 commented Mar 24, 2020 •
edited

There was no force pushes in #7855, but still: "65 successful and 2 neutral checks". Is it expected that there is that many checks?

@fisker
Copy link
Sponsor Member Author

fisker commented Mar 24, 2020

@thorn0 No, it's not. I'll fix it.

@fisker fisker mentioned this pull request Mar 24, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lipis lipis lipis approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fisker @thorn0 @lipis @alexander-akait