Prettier 1.20 - Last 1.x release?

[duailibe]

The latest release (1.19) was in November of last year. We have a few bugfixes that we could be released already before the 2.0 release.

I'll work on this today

[alexander-akait]

@duailibe Which PRs we want to port for 1.20?

[duailibe]

@evilebottnawi I was gonna cut a release from master, but if there are PRs that can be ported easy enough, I'm happy to do it

[thorn0]

I'd say #6949 and #7026. Users complain the most about these two. They are in master, BTW.

[duailibe]

Yes, #6949 is the main reason, which is why a release from master would suffice

[alexander-akait]

@duailibe master contains breaking changes, we can't release this as 1.20, we do not have a lot of work for 2, so I would probably rather not do release 1.20, but if all votes for 1.20, I am ok

[duailibe]

@evilebottnawi what breaking changes?

[graemeworthy]

#7654 does not rely on other items in the 2.0 branch, and can be easily ported, it is not in master.

I have rebased on master:
master...graemeworthy:prettier-ignore-should-also-ignore-text-nodes

[thorn0]

Let's merge #7660 (as is, without addressing this issue) and release 2.0 instead.

[fisker]

#6981

[duailibe]

@thorn0 IMO you shouldn't rush a 2.0 release, but it's your call. I wanted to get those fixes out by today or tomorrow. Do you think 2.0 will be ready by then?

[krilllind]

Would it be possible to release a 1.19.2 patch including issues related to 1.19(.1) and then just wait with 2.0?

I'm for example waiting for this fix to be released.

[heylookltsme]

I'd love to have this included in a minor release, if possible! 🙏

[mvlabat]

I would also love to see the fix of this: #6953

[eps1lon]

#7631 would be nice as well. Generally any change that deals with new syntax would be nice to backport. Otherwise you might get stuck in this weird limbo where you can't upgrade syntax because you can't ugrade prettier.