Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup work on setup github actions #7431

Merged
merged 37 commits into from Mar 23, 2020
Merged

Followup work on setup github actions #7431

merged 37 commits into from Mar 23, 2020

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented Jan 25, 2020 •
edited

@fisker

This comment has been minimized.

Sign in to view
@lipis
Copy link
Member

lipis commented Jan 25, 2020

Let's start removing the common ones..

@fisker
Copy link
Sponsor Member Author

fisker commented Jan 25, 2020

@lipis You mean azure pipelines?

@lipis
Copy link
Member

lipis commented Jan 25, 2020

Yes

@fisker
Copy link
Sponsor Member Author

fisker commented Jan 25, 2020

How about remove it in a separate PR?
Do we need keep both for a while?

@lipis
Copy link
Member

lipis commented Jan 25, 2020

Yes maybe.. let's finalize the gh ones..

@fisker
Copy link
Sponsor Member Author

fisker commented Jan 25, 2020 •
edited

@lipis Please add a CODECOV_TOKEN

@fisker fisker force-pushed the adjust-github-actions branch 5 times, most recently from 7d88632 to a3d7b80 Compare January 25, 2020 19:30
@lipis
Copy link
Member

lipis commented Mar 19, 2020

All green! That means we are ready to get rid of Azure? or they are still doing something more than we do with GitHub?

@fisker
Copy link
Sponsor Member Author

fisker commented Mar 19, 2020 •
edited

@lipis All azure jobs covered, problem is github actions seems slower than azure, especially the one collects coverage.

@lipis
Copy link
Member

lipis commented Mar 21, 2020

I would still go with GitHub...

@fisker
Copy link
Sponsor Member Author

fisker commented Mar 21, 2020

I use github actions too.

Seems faster with --maxWorkers, 20mins vs 15mins, should be acceptable

@thorn0 thorn0 changed the base branch from next to master March 21, 2020 21:02
@lipis
Copy link
Member

lipis commented Mar 21, 2020

Let me know when we can disable Azure :)

@lipis
Copy link
Member

lipis commented Mar 21, 2020

Just remove the .azure directory and we should be fine when you're ready.

@fisker fisker mentioned this pull request Mar 22, 2020
Merged
4 tasks
@fisker
Copy link
Sponsor Member Author

fisker commented Mar 22, 2020

Let's disable it in #7824 , shall we?

@thorn0 thorn0 merged commit 54f907d into prettier:master Mar 23, 2020
@fisker fisker deleted the adjust-github-actions branch March 23, 2020 04:42
@thorn0 thorn0 mentioned this pull request Mar 23, 2020
Merged
3 tasks
thorn0
thorn0 reviewed Mar 24, 2020
View reviewed changes
jest.config.js
@@ -37,4 +37,5 @@ module.exports = {
"jest-watch-typeahead/testname",
],
reporters: ["default"].concat(ENABLE_TEST_RESULTS ? "jest-junit" : []),
verbose: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove this verbose: true? Now Jest prints too much when I run it locally.

Copy link
Sponsor Member Author

@fisker fisker Mar 25, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about set to isCI, yarn test will print less, and yarn test --verbose can still print more

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7866

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thorn0 thorn0 thorn0 approved these changes

@lipis lipis lipis approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fisker @lipis @armano2 @thorn0 @sosukesuzuki