Support TypeScript 3.8 #7263

sosukesuzuki · 2020-01-11T07:56:57Z

TypeScript 3.8 beta has been released!🎉🎉
We should support some syntax will be add via TS 3.8.

There are some syntaxes that can support by just (waiting and) updating typescript-estree(e.g. Top Level await), but there seems to be some that need to be supported on the Prettier side.(e.g. Type only imports exports)

New syntax:

import type, export type
ECMAScript Private Fields
export * as ns

The text was updated successfully, but these errors were encountered:

armano2 · 2020-01-11T15:54:12Z

@sosukesuzuki i will take a look at this next week at typescript-estree site

thorn0 · 2020-01-11T16:12:13Z

A relevant Babel issue: babel/babel#10981 (import type in TypeScript)

simllll · 2020-02-21T16:36:59Z

1:14 Parsing error: '=' expected.
  > 1 | import type { IAPIJobForUser } from '@hokify/common';

right now prettier does not handle the new syntax, any progress on this? can I support somehow?

alexander-akait · 2020-02-21T16:51:42Z

We wait typescript-eslint/typescript-eslint#1465

1984: feat(ts): add TS v3.7/3.8 language features r=spencercorwin a=spencercorwin ### Description of the Change Upgrades Smart-Contract compiler to support new TS language features: Features from TS v3.7: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html - [x] Optional Chaining - [x] Nullish Coalescing - Added in previous TS PR - [x] Assertion Functions - Not supported? - [x] `never`-Returning Functions - No change needed? - [x] Recursive Type Aliases - [x] Uncalled Function Checks - Should be supported without change from us? Features from TS v3.8.1-rc: https://devblogs.microsoft.com/typescript/announcing-typescript-3-8-rc/ - [x] Type-Only Imports and Exports - [x] ECMAScript Private Fields - [x] `export * as ns` Syntax - Added in previous TS PR - [x] Top-Level `await` - Not supported? ### Test Plan - All Unit Tests - `rush test` - `rush e2e` - Optional Chaining - `rush test -t packages/neo-one-smart-contract-compiler/src/__tests__/compile/expression/CallExpressionCompiler.test.ts` - `rush test -t packages/neo-one-smart-contract-compiler/src/__tests__/compile/expression/ElementAccessExpressionCompiler.test.ts` - `rush test -t packages/neo-one-smart-contract-compiler/src/__tests__/compile/expression/PropertyAccessExpressionCompiler.test.ts` - Nullish Coalescing - `rush test -t packages/neo-one-smart-contract-compiler/src/__tests__/compile/expression/ToNullishBooleanHelper.test.ts` - Recursive Type Aliases - `rush test -t packages/neo-one-smart-contract-compiler/src/__tests__/compile/declaration/TypeAliasDeclarationCompiler.test.ts` - Type-Only Imports and Exports - `rush test -t packages/neo-one-typescript-concatenator/src/__tests__/concatenate.test.ts` - ECMAScript Private Fields - `rush test -t packages/neo-one-smart-contract-compiler/src/__tests__/compile/declaration/ClassDeclarationCompiler.test.ts` - `rush test -t packages/neo-one-smart-contract-compiler/src/__tests__/compile/expression/ObjectLiteralExpressionCompiler.test.ts` - `export * as ns` Syntax - `rush test -t packages/neo-one-typescript-concatenator/src/__tests__/concatenate.test.ts` - Top-Level `await` - `rush test -t packages/neo-one-smart-contract-compiler/src/__tests__/compiler/expression/AwaitExpressionCompiler.test.ts` ### Alternate Designs None. ### Benefits - We support the latest language features for writing Smart Contracts in TS. ### Possible Drawbacks - Prettier doesn't support some TS v3.8 syntax yet, so all Prettier checks will fail on the `neo-one-typescript-concatenator` package until they/we update Prettier. They have an issue open for this [here](prettier/prettier#7263). They are waiting for TS 3.8 support in `typescript-eslint` for the new AST [here](typescript-eslint/typescript-eslint#1465). This is easy to ignore for now. - Possibly unforeseen problems. ### Applicable Issues #1889 Co-authored-by: Spencer Corwin <spencercorwin@icloud.com>

bradzacher · 2020-03-10T20:40:42Z

Update on this:
We're currently blocked waiting for ESTree to merge the AST for both export * as ns and private class members.
The former is accepted, but not yet merged, and the latter is still under discussion; I probably would expect at least a few weeks for it to progress.

However, I did merge typescript-eslint/typescript-eslint#1697 on the weekend, which adds support for import/export type.

Would it be a good idea for prettier to bump the ts-estree version to v2.23.0 to help users in the interim?

thorn0 · 2020-03-11T12:58:53Z

For private fields, I added temporary hacks in #7631. They seem to be good enough for now. Most probably we'll merge it before releasing 2.0.

alexander-akait · 2020-03-11T14:41:37Z

Partial fixed #7631, please read https://github.com/thorn0/prettier/blob/41911af745fbc2dfb9d1be0b7146f4c5f8b4f4c5/changelog_unreleased/typescript/pr-7631.md

bradzacher · 2020-03-11T15:50:23Z

before releasing 2.0.

Do you have a timeline for release of this?
Not rushing, just asking because I have typescript-eslint/typescript-eslint#1698 ready, which adds support for export * as ns, but it's waiting on estree/estree#205.

I've pinged back on the ESTree side of things, so hopefully soon we can the spec merged, and then merge our PR.

If the timeline is a week, then I would say we can't get it merged before then, but if it's a few weeks out then there's probably a good chance that we can.

thorn0 · 2020-03-11T15:58:42Z

Thanks. It's not a blocker. If we release earlier, we'll add export * as ns in 2.0.1.

bradzacher · 2020-03-11T17:06:31Z

Update:
estree/estree#205 was merged, so I have merged typescript-eslint/typescript-eslint#1698.
A canary release will be cut shortly, and it will be released to latest Monday morning PST.

ljharb · 2020-03-11T17:08:21Z

Hopefully you’d add something only in a minor, not a patch ;-)

thorn0 · 2020-03-11T21:15:46Z

@ljharb I could as well write "we'll fix it in 2.0.1". Same thing, but suddenly a patch is okay now. Magic!

thorn0 · 2020-03-17T00:44:22Z

closed by #7764, #7631

stnwk · 2020-03-18T17:52:21Z

@thorn0 That's great news, thanks! When do you think we'd be able see this in a release?

BPScott · 2020-03-18T18:13:18Z

@stnwk looks like we're getting fairly close to a 2.0 release: #7778

sosukesuzuki added the lang:typescript Issues affecting TypeScript-specific constructs (not general JS issues) label Jan 11, 2020

This was referenced Jan 11, 2020

TypeScript 3.8: ECMAScript Private Fields #7271

Closed

TypeScript 3.8 Syntax Support typescript-eslint/typescript-eslint#1436

Closed

thorn0 added the scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency label Jan 14, 2020

thorn0 mentioned this issue Jan 14, 2020

TypeScript 3.8: import type & private class fields #7326

Closed

thorn0 pinned this issue Jan 14, 2020

armano2 mentioned this issue Jan 26, 2020

WIP: feat: new ast for typescript 3.8 typescript-eslint/typescript-eslint#1465

Closed

13 tasks

Jack-Works mentioned this issue Feb 5, 2020

[Task] Upgrade to TypeScript 3.8.0 DimensionDev/Maskbook#740

Closed

5 tasks

This was referenced Feb 9, 2020

Support TypeScript 3.8 denoland/deno#3937

Closed

Adopt ECMAScript Private Fields denoland/deno#3980

Closed

thorn0 mentioned this issue Feb 19, 2020

Partial support for TypeScript 3.8 (private fields, import/export type modifier) #7631

Merged

spencercorwin mentioned this issue Feb 24, 2020

feat(ts): upgrade TS to v3.8.1-rc neo-one-suite/neo-one#1980

Merged

ffflorian mentioned this issue Feb 25, 2020

refactor: Use TypeScript 3.8 ffflorian/electron-info#211

Closed

Page- mentioned this issue Feb 27, 2020

Use import type where possible to explicitly import only type info balena-io/balena-cli#1635

Merged

spencercorwin mentioned this issue Feb 27, 2020

feat(ts): add TS v3.7/3.8 language features neo-one-suite/neo-one#1984

Merged

10 tasks

aarjithn mentioned this issue Mar 2, 2020

Update TS syntax rome/tools#12

Closed

dstaley mentioned this issue Mar 4, 2020

Remove JSDOM from tests and create polyfilled Node bundle Kinto/kinto-http.js#700

Merged

sosukesuzuki mentioned this issue Mar 13, 2020

Support TypeScript 3.8 export * as ns syntax #7764

Merged

3 tasks

thorn0 closed this as completed Mar 17, 2020

thorn0 unpinned this issue Mar 17, 2020

mishkinf mentioned this issue Mar 19, 2020

Add support for --isolatedModules MunifTanjim/node-bitbucket#53

Merged

mshustov mentioned this issue Mar 26, 2020

update to TypeScript v3.8-rc elastic/kibana#57774

Closed

7 tasks

sirbrillig mentioned this issue Apr 14, 2020

Typescript warnings about exports not found Automattic/wp-calypso#41113

Closed

github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jun 26, 2020

github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support TypeScript 3.8 #7263

Support TypeScript 3.8 #7263

sosukesuzuki commented Jan 11, 2020 •

edited by thorn0

armano2 commented Jan 11, 2020

thorn0 commented Jan 11, 2020 •

edited

simllll commented Feb 21, 2020

alexander-akait commented Feb 21, 2020

bradzacher commented Mar 10, 2020 •

edited

thorn0 commented Mar 11, 2020

alexander-akait commented Mar 11, 2020

bradzacher commented Mar 11, 2020 •

edited

thorn0 commented Mar 11, 2020

bradzacher commented Mar 11, 2020

ljharb commented Mar 11, 2020

thorn0 commented Mar 11, 2020 •

edited

thorn0 commented Mar 17, 2020

stnwk commented Mar 18, 2020

BPScott commented Mar 18, 2020

Support TypeScript 3.8 #7263

Support TypeScript 3.8 #7263

Comments

sosukesuzuki commented Jan 11, 2020 • edited by thorn0

armano2 commented Jan 11, 2020

thorn0 commented Jan 11, 2020 • edited

simllll commented Feb 21, 2020

alexander-akait commented Feb 21, 2020

bradzacher commented Mar 10, 2020 • edited

thorn0 commented Mar 11, 2020

alexander-akait commented Mar 11, 2020

bradzacher commented Mar 11, 2020 • edited

thorn0 commented Mar 11, 2020

bradzacher commented Mar 11, 2020

ljharb commented Mar 11, 2020

thorn0 commented Mar 11, 2020 • edited

thorn0 commented Mar 17, 2020

stnwk commented Mar 18, 2020

BPScott commented Mar 18, 2020

sosukesuzuki commented Jan 11, 2020 •

edited by thorn0

thorn0 commented Jan 11, 2020 •

edited

bradzacher commented Mar 10, 2020 •

edited

bradzacher commented Mar 11, 2020 •

edited

thorn0 commented Mar 11, 2020 •

edited