Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glimmer] update @glimmer/syntax to "0.38.4" #6185

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

GavinJoyce
Copy link
Contributor

@GavinJoyce GavinJoyce commented Jun 6, 2019

This updated @glimmer/syntax to the latest version that still passes the existing tests, 0.38.4. There appears to be a breaking change in 0.39 which will require some work.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@duailibe duailibe merged commit 79fe6d8 into prettier:master Jun 6, 2019
@GavinJoyce GavinJoyce deleted the gj/upgrade-glimmer-syntax branch June 6, 2019 12:53
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Sep 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 4, 2019
@lipis lipis added this to the 1.19 milestone Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants