-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix (Glimmer): avoid unwanted whitespace in components #6178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Please update changelog
e023521
to
7da00b7
Compare
c42e303
to
d1a951e
Compare
Has CI stalled? https://dev.azure.com/prettier/79013671-677c-4846-a6d8-3050d40e21c0/_build/results?buildId=1003 seems to indicate an error: I'm going to risk going to the back of the CI queue with a rebase to trigger a new CI build EDIT: a rebase seems to have worked |
d1a951e
to
5bac47a
Compare
This is ready for review |
This fixes an issue where unwanted white space was being added to components.
With the following input:
before this PR: (note the extra
before the
/>
and the extra line break)after this PR:
(If changing the API or CLI) I’ve documented the changes I’ve made (in thedocs/
directory)CHANGELOG.unreleased.md
file following the template.✨Try the playground for this PR✨