Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (Glimmer): avoid unwanted whitespace in components #6178

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

GavinJoyce
Copy link
Contributor

@GavinJoyce GavinJoyce commented Jun 5, 2019

This fixes an issue where unwanted white space was being added to components.

With the following input:

<div>
  <UserGreeting
    @aVeryLongArgumentNameThatIsStillGoing={{@alsoAVeryLongArgument}}
  />
</div>

before this PR: (note the extra before the /> and the extra line break)

<div>
  <UserGreeting
    @aVeryLongArgumentNameThatIsStillGoing={{@alsoAVeryLongArgument}}
   />

</div>

after this PR:

<div>
  <UserGreeting
    @aVeryLongArgumentNameThatIsStillGoing={{@alsoAVeryLongArgument}}
  />
</div>
  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please update changelog

@GavinJoyce
Copy link
Contributor Author

Screen Shot 2019-06-05 at 11 53 13

@GavinJoyce GavinJoyce changed the title [WIP] Fix: avoid unwanted whitespace in glimmer components Fix (Glimmer): avoid unwanted whitespace in components Jun 5, 2019
@GavinJoyce GavinJoyce force-pushed the gj/glimmer-improvements branch 2 times, most recently from e023521 to 7da00b7 Compare June 5, 2019 10:57
@GavinJoyce
Copy link
Contributor Author

GavinJoyce commented Jun 5, 2019

Has CI stalled?

https://dev.azure.com/prettier/79013671-677c-4846-a6d8-3050d40e21c0/_build/results?buildId=1003 seems to indicate an error:

Screen Shot 2019-06-05 at 14 26 46

I'm going to risk going to the back of the CI queue with a rebase to trigger a new CI build

EDIT: a rebase seems to have worked

@GavinJoyce
Copy link
Contributor Author

This is ready for review

@duailibe duailibe merged commit 90308eb into prettier:master Jun 5, 2019
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Sep 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants