Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding quotes if there's a numeric literal as key #6138

Merged
merged 4 commits into from
Jun 4, 2019

Conversation

duailibe
Copy link
Member

// input
foo = {
  a: 1,
  1: 1,
};

// output (before)
foo = {
  "a": 1,
  1: 1,
};

Try the playground for this PR

@duailibe
Copy link
Member Author

Note: this still happens

// input
foo = {
  a: 1,
  "1": 1,
};

// output
foo = {
  "a": 1,
  "1": 1,
};

@duailibe duailibe merged commit 2e6191f into prettier:master Jun 4, 2019
@duailibe duailibe deleted the numbers-quote branch June 4, 2019 16:45
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Sep 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant